Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lc dark mode bg image #83

Merged
merged 18 commits into from
Apr 6, 2024
Merged

Lc dark mode bg image #83

merged 18 commits into from
Apr 6, 2024

Conversation

chungleee
Copy link
Collaborator

  • dark mode background image
  • adjust dark mode color for font and border for all cards
  1. git pull origin lc-dark-mode-bg-image
  2. git checkout lc-dark-mode-bg-image
  3. click dark mode and navigate between pages to verify

@chungleee chungleee self-assigned this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Visit the preview URL for this PR (updated for commit a5ced06):

https://tcl-70-smart-shopping-list--pr83-lc-dark-mode-bg-imag-15geo0be.web.app

(expires Sat, 13 Apr 2024 18:42:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7bb526f3a6607712c7f73ffd6c0dfff4c62b86d9

Copy link
Collaborator

@amandaguan-ag amandaguan-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two list names font color is blue blending in with the background, other list names are good
image

@amandaguan-ag
Copy link
Collaborator

@chungleee Hi Leon, do you want to try adding a white border to log in box to seperate it from the background
image

@chungleee chungleee merged commit 9f19593 into main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants