Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20: Finalize Logo and Favicon Integration #58

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Conversation

dterceroparker
Copy link
Member

@dterceroparker dterceroparker commented Oct 9, 2024

Description

This pull request finalizes the logo and favicon for the project. We have purchased a logo from BrandCrowd, initially using the transparent version. However, during testing, the transparent logo appeared as line squiggles in the favicon, which affected clarity. As a result, we generated the favicon using the version of the logo with a white background for better visibility and sharpness.

Related Issue

Closes #47

Acceptance Criteria

  • Purchase and finalize BrandCrowd logo.
  • Team discussion to finalize logo colors aligned with the project’s color palette.
  • Generate favicon using the logo image.
  • Ensure the favicon is correctly integrated into the project.
  • Follow the project’s color palette during logo and favicon creation.

Type of Changes

Enhancement
Refactor

Updates

After

Screen Shot 2024-10-10 at 12 27 49 PM

Screen Shot 2024-10-10 at 12 35 19 PM

Testing Steps / QA Criteria

  • Ensure that the favicon appears correctly in the browser tab, confirming the white background version is being used.
  • View the logo on the Landing page (logged out) and Layout page (signed in) using the inspector tool (toggle device toolbar) for cell phone dimensions.
  • Check that the logo scales smoothly on hover and remains responsive across different screen sizes.

@dterceroparker dterceroparker self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 7a231b3):

https://tcl-74-smart-shopping-list--pr58-dtp-logo-sm7rtn6y.web.app

(expires Fri, 18 Oct 2024 15:42:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

@dterceroparker dterceroparker changed the title Issue #20: Logo & Favicon Issue #20: Finalize Logo and Favicon Integration Oct 9, 2024
@dterceroparker dterceroparker marked this pull request as ready for review October 10, 2024 16:37
@dterceroparker dterceroparker added enhancement New feature or request refactoring labels Oct 10, 2024
Copy link
Collaborator

@NickRoccodev11 NickRoccodev11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo looks fantastic, thanks for getting that taken care of!

Copy link
Collaborator

@shuveksha-tuladhar shuveksha-tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dterceroparker dterceroparker merged commit 10a3553 into main Oct 11, 2024
2 checks passed
@dterceroparker dterceroparker deleted the dtp-logo branch October 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

20 Logo & Favicon: Decide Tool to Use and Finalize
4 participants