-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #20: Finalize Logo and Favicon Integration #58
Conversation
Visit the preview URL for this PR (updated for commit 7a231b3): https://tcl-74-smart-shopping-list--pr58-dtp-logo-sm7rtn6y.web.app (expires Fri, 18 Oct 2024 15:42:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 79d73546692f99aad8468c28e36db434e2c190ac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logo looks fantastic, thanks for getting that taken care of!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description
This pull request finalizes the logo and favicon for the project. We have purchased a logo from BrandCrowd, initially using the transparent version. However, during testing, the transparent logo appeared as line squiggles in the favicon, which affected clarity. As a result, we generated the favicon using the version of the logo with a white background for better visibility and sharpness.
Related Issue
Closes #47
Acceptance Criteria
Type of Changes
Enhancement
Refactor
Updates
After
Testing Steps / QA Criteria