Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light Mode Feature #61

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Dark/Light Mode Feature #61

merged 4 commits into from
Oct 10, 2024

Conversation

stacy-tech
Copy link
Contributor

Description

This PR implements a theme toggle feature, allowing users to switch between light and dark modes manually.

Related Issue

Updates

Before

Image

After

darkmode

Type of Changes

Enhancement
Accessibility

Copy link

Visit the preview URL for this PR (updated for commit 45ef3fd):

https://tcl-74-smart-shopping-list--pr61-light-dark-tpbtz0an.web.app

(expires Thu, 17 Oct 2024 04:26:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 79d73546692f99aad8468c28e36db434e2c190ac

Copy link
Collaborator

@shuveksha-tuladhar shuveksha-tuladhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful! I really love the moon icon.

Copy link
Member

@dterceroparker dterceroparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how it looks in dark mode! Great work, Stacy! I also noticed the sun icon appeared once I logged in. Should we place the icon in the same location as when logged out (all the way at the top)? Overall, fantastic job!

Copy link
Collaborator

@NickRoccodev11 NickRoccodev11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! I like the icons, looks great!

@stacy-tech stacy-tech merged commit df5ac85 into main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark/Light Mode Feature
4 participants