Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address fields for Stripe payment #3125

Merged
merged 16 commits into from
Jul 25, 2024

Conversation

pattihis
Copy link
Contributor

@pattihis pattihis commented Jul 24, 2024

🎫 Ticket

ETP-934

🗒️ Description

If Stripe is our payment gateway, and if more payment methods than simple Credit Cards are available, then we render a form to collect users address and we pass that to Stripe as billing and shipping data.

✔️ Checklist

  • Ran npm run changelog to add changelog file(s).
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@pattihis pattihis added the code review Status: requires a code review. label Jul 24, 2024
@pattihis pattihis self-assigned this Jul 24, 2024
pattihis added 3 commits July 24, 2024 03:30
…event-tickets into fix/Address_fields_for_Stripe_Payment

# Conflicts:
#	readme.txt
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple of tweaks

readme.txt Outdated Show resolved Hide resolved
src/resources/js/commerce/gateway/stripe/checkout.js Outdated Show resolved Hide resolved
src/resources/postcss/tickets-commerce/_checkout.pcss Outdated Show resolved Hide resolved
src/views/v2/commerce/checkout/gateways.php Outdated Show resolved Hide resolved
src/views/v2/commerce/checkout/purchaser-info.php Outdated Show resolved Hide resolved
src/views/v2/commerce/checkout/purchaser-info.php Outdated Show resolved Hide resolved
src/views/v2/commerce/checkout/purchaser-info.php Outdated Show resolved Hide resolved
@pattihis pattihis requested a review from borkweb July 24, 2024 07:38
Copy link
Member

@borkweb borkweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed some small grammar changes when I did the review last night 🥼

codingmusician
codingmusician previously approved these changes Jul 24, 2024
@pattihis pattihis requested a review from borkweb July 24, 2024 17:49
borkweb
borkweb previously approved these changes Jul 25, 2024
@dpanta94 dpanta94 dismissed stale reviews from borkweb and codingmusician via 1fe8a8b July 25, 2024 12:55
dpanta94
dpanta94 previously approved these changes Jul 25, 2024
George Pattichis added 2 commits July 25, 2024 16:07
…e-events-calendar/event-tickets into fix/Address_fields_for_Stripe_Payment

* 'fix/Address_fields_for_Stripe_Payment' of github.com:the-events-calendar/event-tickets:
  Updating snapshots
  ⏩ the-events-calendar/tribe-common@eb6385b
  Indentation
  Design/QA review changes
  Grammar Check
@pattihis pattihis merged commit 278983d into release/T24.centaur Jul 25, 2024
13 of 16 checks passed
@pattihis pattihis deleted the fix/Address_fields_for_Stripe_Payment branch July 25, 2024 13:16
@pattihis pattihis restored the fix/Address_fields_for_Stripe_Payment branch July 26, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants