-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address fields for Stripe payment #3125
Merged
pattihis
merged 16 commits into
release/T24.centaur
from
fix/Address_fields_for_Stripe_Payment
Jul 25, 2024
Merged
Address fields for Stripe payment #3125
pattihis
merged 16 commits into
release/T24.centaur
from
fix/Address_fields_for_Stripe_Payment
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event-tickets into fix/Address_fields_for_Stripe_Payment # Conflicts: # readme.txt
borkweb
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A couple of tweaks
borkweb
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed some small grammar changes when I did the review last night 🥼
src/admin-views/settings/tickets-commerce/stripe/modal/signup-complete/content.php
Outdated
Show resolved
Hide resolved
…e-events-calendar/event-tickets into fix/Address_fields_for_Stripe_Payment
codingmusician
previously approved these changes
Jul 24, 2024
borkweb
previously approved these changes
Jul 25, 2024
dpanta94
previously approved these changes
Jul 25, 2024
…e-events-calendar/event-tickets into fix/Address_fields_for_Stripe_Payment * 'fix/Address_fields_for_Stripe_Payment' of github.com:the-events-calendar/event-tickets: Updating snapshots ⏩ the-events-calendar/tribe-common@eb6385b Indentation Design/QA review changes Grammar Check
dpanta94
approved these changes
Jul 25, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
ETP-934
🗒️ Description
If Stripe is our payment gateway, and if more payment methods than simple Credit Cards are available, then we render a form to collect users address and we pass that to Stripe as billing and shipping data.
✔️ Checklist
npm run changelog
to add changelog file(s).wpunit
orintegration
tests.wpunit
orintegration
tests.