Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/et 2148 rebased undefined provider #3127

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

dpanta94
Copy link
Member

@dpanta94 dpanta94 commented Jul 24, 2024

🎫 Ticket

ET-2148

This is a copy of #3120

🗒️ Description

A provider was not being set to a global property. On block init, set the provider.

🎥 Artifacts

Uncaught TypeError: format is undefined
    cleanNumber https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-utils.js?ver=5.11.0.5:88
    getPrice https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-utils.js?ver=5.11.0.5:225
    getPrice https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:476
    updateFooterAmount https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:200
    jQuery 2
    updateFooterAmount https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:189
    updateFooter https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:125
    bindTicketsQuantityInput https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:647
    jQuery 7
    bindTicketsAddRemove https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:569
    jQuery 10
    bindTicketsAddRemove https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:544
    bindEvents https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:807
    ready https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:829
    jQuery 2
    ready https://test.lndo.site/wp-content/plugins/event-tickets/src/resources/js/v2/tickets-block.js?ver=5.11.0.5:828
    jQuery 13
tickets-utils.js:88:20

✔️ Checklist

  • Changelog entry in the readme.txt file.
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@dpanta94 dpanta94 requested review from stratease and Camwyn July 24, 2024 13:48
@dpanta94 dpanta94 self-assigned this Jul 24, 2024
Camwyn
Camwyn previously approved these changes Jul 24, 2024
readme.txt Outdated Show resolved Hide resolved
@Camwyn Camwyn merged commit e21e236 into release/T24.chapa.2 Jul 24, 2024
11 of 14 checks passed
@Camwyn Camwyn deleted the fix/ET-2148-rebased-undefined-provider branch July 24, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants