Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ET-2273] Fix show screen options filter in ET #3462

Merged

Conversation

codingmusician
Copy link
Contributor

@codingmusician codingmusician commented Dec 18, 2024

🎫 Ticket

ET-2273

🗒️ Description

The screen_options_show_screen filter should always return what is passed into the filter if it doesn't meet the requirements, not change it to false. This was causing Screen Options to not show when not on the Tickets List page, throughout WordPress. Not good.

🎥 Artifacts

Before fix:
image

After fix:
image

✔️ Checklist

  • Ran npm run changelog to add changelog file(s). More info here
  • Code is covered by NEW wpunit or integration tests.
  • Code is covered by EXISTING wpunit or integration tests.
  • Are all the required tests passing?
  • Automated code review comments are addressed.
  • Have you added Artifacts?
  • Check the base branch for your PR.
  • Add your PR to the project board for the release.

@codingmusician codingmusician marked this pull request as ready for review December 18, 2024 13:53
@codingmusician codingmusician self-assigned this Dec 18, 2024
@codingmusician codingmusician added the code review Status: requires a code review. label Dec 18, 2024
@codingmusician codingmusician merged commit fc12e3f into release/T25.imp Dec 18, 2024
20 of 22 checks passed
@codingmusician codingmusician deleted the fix/ET-2273-et-removing-screen-options branch December 18, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Status: requires a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants