-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add The Neue Black #1
base: main
Are you sure you want to change the base?
Conversation
Hello @micahbrich and @alerque 👋 I just found this PR, could you take a look?
Let me know what you think, so we can move the project forward :) |
Woof. I really can't merge this, sorry @emmamarichal. If you'd like to contribute improvements without moving the fontship file or adding unnecessary text docs or removing the RFN, we'd happily accept improvements. Removing the RFN is a no-go — as far as I know, that would strip away all rights anyone has. Is there any compromise here that benefits everyone? Why is this necessary? Is there any way for Google to contribute without taking rights away or making a fork that would give no credit to the original designers and end up confusing everyone? |
Hello @micahbrich, I'm sorry, I didn't specify, but I work for GF, for the fonts onboarding, with @RosaWagner. As far as .txt are concerned, we follow templates to try to have similar repos, which can be easily used by fonts onboarders or contributors. For the RFN, maybe @davelab6 can explain it better than me? |
Hi @micahbrich, thanks for answering this PR. The RFN is not about credit to authors, those are specified in .txt files: AUTHORS.txt and CONTRIBUTORS.txt, the copyright string in the license refers to those files. The RFN protects the font from being forked and released under the same name by someone else. It means that anyone modifying the font (even metadata) should release the modification under another name. GF can’t publish a font with an RFN without the explicit written consent of all the authors because the font served by the API is subsetted and they don’t want to fork and give another name for that, it would not give enough credit to the authors. Although if the authors really want to keep the RFN, we have a process for that (basically an email from the authors giving consent). If you are interested, I can send you the template email for that. You can also say that you don’t want this font on GF, no one is trying to give away rights here. You can simply answer to this issue so we can close and have an archive. |
Hello,
Here are the changes made according to GF spec:
As for the name of the font, we have to name the style 'Regular'. I invite you to read the discussion on this topic:
google/fonts#4372 (comment)
I removed the RFN from OFL.txt and sources. You can merge if you approve.
If you don't want the RFN removal, you can read what Dave said about it, and I'll re-add it back in this PR before you merge.
Cheers!