Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nick Colours for v4.4.0 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aab12345
Copy link

@aab12345 aab12345 commented Mar 28, 2023

PR #4649 update #chat.colored-nicks CSS selector.

Copy link
Member

@brunnre8 brunnre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably adapt the theme so that only the new selectors remain.
The old ones aren't useful once we release the new TL version.

As for the commit messages, it isn't a regression but a change that was done on purpose, so please reword that ;)

It was a regression for the morning theme, as there the change was forgotten originally. It isn't for normal themes that just update for the new version of the code.

theme.css Outdated
@@ -211,6 +211,42 @@ form.message-search input {
color: var(--body-color);
}

/* Nick Colour Fix for 4.4.0 */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of that comment, it isn't useful in the future for readers of the code.
They will be working with the latest version.

Copy link
Author

@aab12345 aab12345 Mar 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment removed below.

@aab12345 aab12345 force-pushed the master branch 2 times, most recently from 2060b3c to d4fc4d8 Compare March 28, 2023 22:10
@brunnre8
Copy link
Member

This doesn't just update the selector, but completely modifies the colors.
This is unexpected, all it should be doing is change the selector based on the commit message

Copy link
Member

@brunnre8 brunnre8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed up to do the minimal changes necessary

@aab12345
Copy link
Author

So it should be (example)

.user.color-1 { color: #ef4657; }
.user.color-17 { color: #ef4657; }

.user.color-2 { color: #ff93a4; }
.user.color-18 { color: #ff93a4; }

etc etc ? I think I got it this time, correct me if I'm wrong again.

@brunnre8
Copy link
Member

No, there's no need to duplicate the color.
Simply delete every occurrence of #chat.colored-nicks and leave the rest alone

@aab12345 aab12345 force-pushed the master branch 3 times, most recently from 3d841f5 to a76e755 Compare March 29, 2023 09:44
This was referenced Mar 29, 2023
PR #4649 update for `#chat.colored-nicks` CSS selector. Update Nick Colours for v4.4.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants