You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
As far as I see, this is the wrong solution. I didn't test it but it seems to break SysEx messages.
There are two solutions:
add doDecode = true before the added break
use fallthrough syntax from C++11
The second one is implemented in pull request Implement a reliable port selection API #30. There I have spent some time to get it running for pre C++11 compilers as well as for C++11 conforming compilers that emit warnings.
3155671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see, this is the wrong solution. I didn't test it but it seems to break SysEx messages.
There are two solutions:
doDecode = true
before the added breakThe second one is implemented in pull request Implement a reliable port selection API #30. There I have spent some time to get it running for pre C++11 compilers as well as for C++11 conforming compilers that emit warnings.