Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HL inferfaces: don't create train-test collectors if not training #1208

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

MischaPanch
Copy link
Collaborator

Minor fix/extension

@MischaPanch MischaPanch requested a review from opcode81 August 14, 2024 14:43
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (94e097b) to head (ca7a7ab).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files         102      102           
  Lines        8667     8674    +7     
=======================================
+ Hits         7405     7411    +6     
- Misses       1262     1263    +1     
Flag Coverage Δ
unittests 85.43% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opcode81
Copy link
Collaborator

LGTM

@MischaPanch MischaPanch merged commit b8f3156 into master Aug 14, 2024
4 checks passed
@MischaPanch MischaPanch deleted the fix/hl-interface-no-training branch August 14, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants