-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add calibration to CQL as in CalQL paper arXiv:2303.05479 #915
Conversation
If possible, pls wait until #912 is merged, as it will certainly introduce conflicts. It is now ready to be merged (CI is green), so I hope it will be quick |
Yes sure no problem. I close this one for now until after your merge. |
Thank you, appreciate it! |
You can go for it now ;) |
Awsome, congrats on the big Merge! |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 90.74% 90.75% +0.01%
==========================================
Files 72 72
Lines 5292 5321 +29
==========================================
+ Hits 4802 4829 +27
- Misses 490 492 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@BFAnas I will try review this in the near future. Could you pls resolve the conflicts with master? We now have a new built and the newest formatting (for py3.11) |
Hi @MischaPanch, |
@BFAnas Thanks! The overrides dependency will be added in #950 anyway, so might as well add it here. Pls run In python 3.12 override will become part of the language, so might as well start using it now. For tianshou it's even particularly useful. After that, the MR is ready for merge, thank you a lot for the contribution! |
Done! |
@Trinkle23897 this one is ready to merge, but the GPU runner seems to have problems, and I can't click the merge button. Could you do that, or fix the GPU runner? Alternatively, you could change the repository settings such that I can merge without all checks being green. EDIT: almost ready to merge, see comments below |
Co-authored-by: Jiayi Weng <[email protected]>
Small typing improvement, related to thu-ml/tianshou#915 (comment)
make format
(required)make commit-checks
(required)