logger: fix file open issue if crypto algorithm is disabled #857
+65
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
reviewed
Dec 27, 2024
jlaitine
reviewed
Dec 27, 2024
jnippula
force-pushed
the
fix-logger-no-crypto
branch
from
9188888 to
b0a780b
Compare
|
Right, it was a bit confusing where and when the file is opened and how. Original idea was to create file already in init_logfile_encryption() even there is no key data (no_crypto) and then start_log would any case open file as append. Anyway, I made it now a bit different way: init_logfile_encryption() now gets keydata/keydatasize as param, allocate memory and store keydata there. Later the LogFileBuffer::start_log() gets the keydata buffer and if any data exists, it stores the keydata into the beginning of the recently opened file. How that looks? |
Store keydata into memory buffer in init phase. If keydata exists, write it into the beginning of the file when file is opened in LogFileBuffer::start_log()
jnippula
force-pushed
the
fix-logger-no-crypto
branch
from
b0a780b to
eb54001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create empty file even if crypto key is not stored into the beginning of the log file to allow file logger to always append log data into existing file.