Skip to content

Commit

Permalink
test_sbomnix.py: skip vulnxscan --triage tests
Browse files Browse the repository at this point in the history
`vulnxscan --triage` shells out to repology_cli again, which doesn't
work - both of them should be independent entrypoints, rather than
calling each other.

We should probably move all the repology-related code into a library
directory, and call it from both vulnxscan --triage and repology_cli.

Signed-off-by: Florian Klink <[email protected]>
  • Loading branch information
flokli committed Nov 14, 2023
1 parent 94e0fdf commit 0f220d7
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions tests/test_sbomnix.py
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,9 @@ def test_vulnxscan_scan_sbom():
])


@pytest.mark.skip_in_ci
@pytest.mark.skip
# vulnxscan --triage assumes repology_cli in $PATH.
# TODO: expose this as library code?
def test_vulnxscan_triage():
"""Test vulnxscan scan with --triage"""
out_path_vulns = TEST_WORK_DIR / "vulnxscan_test.csv"
Expand All @@ -491,7 +493,9 @@ def test_vulnxscan_triage():
])


@pytest.mark.skip_in_ci
@pytest.mark.skip
# vulnxscan --triage assumes repology_cli in $PATH.
# TODO: expose this as library code?
def test_vulnxscan_triage_whitelist():
"""Test vulnxscan scan with --triage and --whitelist"""
out_path_vulns = TEST_WORK_DIR / "vulnxscan_test.csv"
Expand Down Expand Up @@ -555,6 +559,9 @@ def test_nix_outdated_help():
_run_python_script([NIX_OUTDATED, "-h"])


@pytest.mark.skip
# vulnxscan --triage assumes repology_cli in $PATH.
# TODO: expose this as library code?
def test_nix_outdated_result():
"""Test nix_outdated with TEST_NIX_RESULT as input"""
out_path_nix_outdated = TEST_WORK_DIR / "nix_outdated.csv"
Expand Down

0 comments on commit 0f220d7

Please sign in to comment.