-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve integration with nixpkgs metadata #100
Conversation
f5aa312
to
0cbf813
Compare
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly a quick glance, but nothing poked my eye.
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Signed-off-by: Henri Rosten <[email protected]>
Had to push another version due to missing This went unnoticed before, because the dependecy was in devshell, but not in |
Signed-off-by: Henri Rosten <[email protected]>
Added more logging in: https://github.com/tiiuae/sbomnix/compare/e210ed8c881f76a5900a8c9dc26e8a05885f177d..b137ee1c9bc64ac0e72cd6d4458740cec32a9a56 as I noticed in testing on larger targets (such as Ghaf), that the tools were suspiciously silent while evaluating and force-realising the target, which can take some time on larger build targets and might raise some concerns for the command-line user. After adding those traces, the tools output some more info as to what is taking time. |
Signed-off-by: Henri Rosten <[email protected]>
This change improves the way sbomnix reads nixpkgs metadata:
nixmeta
, which allows summarizing nixpkgs meta-attributes from the given nixpkgs version.nixmeta
based on the given sbomnix target. Additionally, if available, pre-populate the meta cache from an online database, maintained and daily-updated on github.Made possible by the above changes, this PR removes the
sbomnix
command-line argument--meta
: meta-information is now automatically added for all sbomnix SBOMs.Also worth noting is that this PR changes
sbomnix
,nixgraph
,vulnxscan
, andnix_outdated
so each tool allows specifying the target as Nix flake reference in addition to the earlier nix store path (which is still also supported).Other smaller changes:
Once this PR is merged, we can close the issue: #62.