Optimize provenance generation speed #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the provenance generator ~60x speed increase when generating recursive provenance for a big system image, from 5 minutes to 5 seconds, without removing any data. In fact, the detail of the provenance is even increased now with the addition of
--include-outputs
flag, adding previously missing dependencies to the array.The nix commands themselves are fast but the
subprocess.run()
calls for every dependency in the loop was causing significant overhead. Upon reading the nix docs I found out that you can pass as many derivations as you want in one nix-store query, and you will get the result for all of them, so we can compute all hashes before the loop in single command.