Lint Tiltfiles with ruff and fix findings #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbast
force-pushed
the
tiltfile-lint
branch
2 times, most recently
from
a6d1e78 to
13f87ff
Compare
Signed-off-by: Daniel Bast <[email protected]>
dbast
commented
Dec 23, 2024
Comment on lines
+18
to
+19
| files: ^.*Tiltfile|^.*\.py$ | ||
| types_or: [text] |
There was a problem hiding this comment.
Can be updated to types_or: [python, starlark] (without further files definition) once this gets accepted pre-commit/identify#494 and released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable linting Tiltfiles via ruff and fix findings. As Tilfiles/Starlark is a subset of Python, we need to disable some Ruff rules that don't apply (done in the pyproject.toml).
This finds unused variables, ambiguous named variables (l is hard to distinguish from 1 or L depending what IDE font is used), mixing of tab/spaces used for indentation, etc.
The commit of this PR can be potentially added to a
.git-blame-ignore-revsafter merge, see also https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/