Track packages compiled into sysimage #688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktdq
changed the title
timholy
reviewed
Jul 23, 2022
There was a problem hiding this comment.
I'm not a PackageCompiler user, but this seems great! Many thanks for contributing this.
I left one comment, but otherwise:
- this could use a test. You could test the error condition I proposed in my comment, and for a working case you could manually create a
Base.pkgoriginsentry. I know that writing these tests is a little annoying but it's the only way to keep Revise working across Julia versions (it breaks with literally every new Julia point release since Revise and its supporting infrastructure reach deep into Julia's guts). - this seems NEWS-worthy to me
| @@ -94,7 +95,14 @@ function _track(id, modname; modified_files=revision_queue) | |||
| track_subdir_from_git!(pkgdata, compilerdir; modified_files=modified_files) | |||
| # insertion into pkgdatas is done by track_subdir_from_git! | |||
| else | |||
| error("no Revise.track recipe for module ", modname) | |||
| pkgdata = watch_package(id) | |||
| modtime = mtime(Base.pkgorigins[id].cachepath) | |||
There was a problem hiding this comment.
What happens if you do this?
julia> module EmptyModule end
Main.EmptyModule
julia> Revise.track(EmptyModule)
ERROR: no Revise.track recipe for module EmptyModule
Stacktrace:
[1] error(::String, ::Symbol)
@ Base ./error.jl:44
[2] _track(id::Base.PkgId, modname::Symbol; modified_files::Set{Tuple{Revise.PkgData, String}})
@ Revise ~/.julia/packages/Revise/VskYC/src/recipes.jl:97
[3] #track#44
@ ~/.julia/packages/Revise/VskYC/src/recipes.jl:12 [inlined]
[4] track(mod::Module)
@ Revise ~/.julia/packages/Revise/VskYC/src/recipes.jl:9
[5] top-level scope
@ REPL[2]:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.