Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently hit an edge case in LazySets.jl where a
@require Package="<UUID>" nothing
statement would not hit theadd_require
dispatch in Revise because thenothing
is parsed as aSymbol
, not anExpression
. I have thus widened the type constraint inadd_expression
to acceptUnion{Expr,Symbol}
and adjusted the body to always convert to an Expr first.The test that I added fails on master but works with this PR. However, there may be a more meaningful test to write here. I'm not too familiar with the test structure here.