fix(configuration): extensions now explicitly required as in webpack

release-npm
tobua · Jan 10, 2024 · b9863bf · b9863bf
1 parent 1153f89
commit b9863bf
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 1 deletion.
diff --git a/configuration/rspack.ts b/configuration/rspack.ts
@@ -86,6 +86,7 @@ export default (development: boolean): RspackOptions => {
     plugins: getPlugins(development, getPublicPath()),
     resolve: {
       modules: getRoots(),
+      extensions: ['...', '.tsx', '.ts', '.jsx'], // "..." means to extend from the default extensions
     },
     module: {
       // Matched from bottom to top!

diff --git a/test/build.test.ts b/test/build.test.ts
@@ -977,3 +977,17 @@ test('Can import fonts.', async () => {
   const mainJsContents = contentsForFilesMatching('*.js', dist)[0].contents
   expect(mainJsContents).toContain('.woff2')
 })
+
+test('Absolute imports can be used.', async () => {
+  const { dist } = prepare([
+    packageJson('absolute'),
+    file('index.jsx', `import { greeting } from 'hello/world'; console.log(greeting)`),
+    file('hello/world.jsx', 'export const greeting = "HEY"'),
+  ])
+
+  await build(false)
+
+  const mainJsContents = contentsForFilesMatching('*.js', dist)[0].contents
+
+  expect(mainJsContents).toContain('HEY')
+})
diff --git a/test/typescript.test.ts b/test/typescript.test.ts
@@ -1,6 +1,14 @@
 import { existsSync } from 'fs'
 import { test, expect, vi } from 'vitest'
-import { environment, prepare, packageJson, file, writeFile, readFile } from 'jest-fixture'
+import {
+  environment,
+  prepare,
+  packageJson,
+  file,
+  writeFile,
+  readFile,
+  contentsForFilesMatching,
+} from 'jest-fixture'
 import { build, configure } from '../index'
 
 environment('typescript')
@@ -42,3 +50,27 @@ test('Build with typescript errors fails.', async () => {
     ),
   ).toBe(true)
 })
+
+test('Absolute imports can be used in TypeScript.', async () => {
+  const { dist } = prepare([
+    packageJson('typescript-absolute'),
+    file('index.tsx', `import { greeting } from 'hello/world'; console.log(greeting)`),
+    file('hello/world.tsx', 'export const greeting = "HEY"'),
+  ])
+
+  writeFile(
+    'node_modules/papua/configuration/.prettierignore',
+    readFile('../../../configuration/.prettierignore'),
+  )
+  writeFile(
+    'node_modules/papua/configuration/template.html',
+    readFile('../../../configuration/template.html'),
+  )
+
+  await configure() // Required for tsconfig.json
+  await build(false)
+
+  const mainJsContents = contentsForFilesMatching('*.js', dist)[0].contents
+
+  expect(mainJsContents).toContain('HEY')
+})