catching socket.timeout using tuple exception #8

tomaae · Mar 13, 2020 · 0f7ad23 · 0f7ad23
1 parent b20d140
commit 0f7ad23
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/custom_components/mikrotik_router/librouteros_custom/connections.py b/custom_components/mikrotik_router/librouteros_custom/connections.py
@@ -22,13 +22,13 @@ def read(self, length):
         """
         data = bytearray()
         while len(data) != length:
+            tmp = None
             try:
                 tmp = self.sock.recv((length - len(data)))
             except:
                 raise ConnectionClosed('Socket recv failed.')
-            finally:
-                data += tmp
 
+            data += tmp
             if not data:
                 raise ConnectionClosed('Connection unexpectedly closed.')
         return data

diff --git a/custom_components/mikrotik_router/mikrotikapi.py b/custom_components/mikrotik_router/mikrotikapi.py
@@ -172,6 +172,19 @@ def path(self, path) -> list:
             self.lock.release()
             return None
 
+        try:
+            tuple(response)
+        except librouteros_custom.exceptions.ConnectionClosed as api_error:
+            _LOGGER.error("Mikrotik %s error while path %s", self._host, api_error)
+            self.disconnect()
+            self.lock.release()
+            return None
+        except:
+            _LOGGER.error("Mikrotik %s error while path %s", self._host, "unknown")
+            self.disconnect()
+            self.lock.release()
+            return None
+
         self.lock.release()
         return response if response else None