Merge pull request #419 from l2es/HAL

Add application/hal+json content-type support

README.md

@@ -613,7 +613,14 @@ To run the tests with debug logs, set the environment variable `NODE_DEBUG` to `
 
 > Note: Tests currently only work on linux-based environments that have `/proc/self/fd`. They *do not* work on MacOS environments.
 > You can use Docker to run tests by creating a container and mounting the needle project directory on `/app`
-> `docker create --name Needle -v $(pwd) -w /app -v $(pwd)/node_modules -i node:argon`
+
+    docker create --name Needle -v $(pwd) -w /app -v $(pwd)/node_modules -i node:argon
+
+Or alternatively:
+
+    docker run -it -w /app --name Needle \
+    --mount type=bind,source="$(pwd)",target=/app \
+    node:fermium bash
 
 Credits
 -------

lib/parsers.js

@@ -97,6 +97,7 @@ function buildParser(name, types, fn) {
 
 buildParser('json', [
   'application/json',
+  'application/hal+json',
   'text/javascript',
   'application/vnd.api+json'
 ], function(buffer, cb) {

test/parsing_spec.js

@@ -544,4 +544,45 @@ describe('parsing', function(){
 
   });
 
+  describe('when response is a HAL JSON content-type', function () {
+
+    var json_string = '{"name": "Tomás", "_links": {"href": "https://github.com/tomas/needle.git"}}';
+
+    before(function(done){
+      server = http.createServer(function(req, res) {
+        res.setHeader('Content-Type', 'application/hal+json');
+        res.end(json_string);
+      }).listen(port, done);
+    });
+
+    after(function(done){
+      server.close(done);
+    });
+
+    describe('and parse option is not passed', function() {
+
+      describe('with default parse_response', function() {
+
+        before(function() {
+          needle.defaults().parse_response.should.eql('all')
+        })
+
+        it('should return object', function(done){
+          needle.get('localhost:' + port, function(err, response, body){
+            should.ifError(err);
+            body.should.deepEqual({
+              'name': 'Tomás',
+              '_links': {
+                'href': 'https://github.com/tomas/needle.git'
+              }});
+            done();
+          });
+        });
+
+      });
+
+    })
+
+  });
+
 })