Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use deprecated API in webpack4 #24

Closed
wants to merge 1 commit into from

Conversation

jquense
Copy link

@jquense jquense commented May 10, 2018

fixes #22

Sorry did this in the GH editor!

@jankanty
Copy link

Hey. These errors looks like they are not working properly in ci: This is likely because this test is run in a continuous integration (CI) environment in which snapshots are not written by default. Can you look at it and consider accepting this PR?

@anthonyhastings
Copy link

Changes look correct to me; I'm looking forward to getting this deprecation warning out of my console!

@kylecesmat
Copy link

@jquense @jankanty @stipsan is there anything blocking this from being merged/released? It's a minor warning, but would be nice to have it removed from output :)

@stipsan
Copy link
Contributor

stipsan commented Jul 3, 2018

The ci error should be fixable by running npm test — -u and pushing the updated snapshots. Although it looks like the same error is happening in master, ot doesn't look like thos PR broke any test 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning with webpack 4
5 participants