Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to merge patch #345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JacobHenner
Copy link
Contributor

Add fallback to merge patch if strategic merge patch is unavailable, as is the case for the custom objects API.

@JacobHenner JacobHenner force-pushed the merge-patch-fallback branch 2 times, most recently from b57fd8c to 3d720e2 Compare December 18, 2024 04:07
Add fallback to merge patch if strategic merge patch is unavailable, as
is the case for the custom objects API.
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 26.91%. Comparing base (84e4e28) to head (d886878).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
kubernetes_asyncio/e2e_test/test_client.py 0.00% 14 Missing ⚠️
kubernetes_asyncio/client/api_client.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
- Coverage   26.91%   26.91%   -0.01%     
==========================================
  Files         799      799              
  Lines       98316    98332      +16     
==========================================
  Hits        26463    26463              
- Misses      71853    71869      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobHenner
Copy link
Contributor Author

I will get to the tests when I can.

@JacobHenner
Copy link
Contributor Author

I will get to the tests when I can.

@tomplus I started writing tests, but I noticed that the unit tests for the CustomObjects API are only stubs. There are e2e tests, but there are no e2e tests for CustomObjects (excluding the DynamicClient). Would you like these e2e tests to be added (which would include creating a CRD, creating a custom object of the CRD's type, and then patching the new custom object)?

@tomplus
Copy link
Owner

tomplus commented Dec 26, 2024

Absolutely, it'd be fantastic to have such tests.

@JacobHenner JacobHenner force-pushed the merge-patch-fallback branch from 5098e73 to d886878 Compare January 5, 2025 04:35
@JacobHenner JacobHenner marked this pull request as ready for review January 5, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants