Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Add filter to disable dynamic tag previews in editor #1607

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

iansvo
Copy link
Collaborator

@iansvo iansvo commented Dec 18, 2024

Closes #1583

@iansvo iansvo linked an issue Dec 18, 2024 that may be closed by this pull request
@tomusborne
Copy link
Owner

Aside from the comments above this looks good. Any reason you chose to go with enabled and disabled vs just letting the true or false of the filter come through?

@iansvo
Copy link
Collaborator Author

iansvo commented Dec 20, 2024

@tomusborne When you add stuff in the inline script output like that it doesn't actually use true/false, it just sets the value to a number. So I figured this would be a bit more obvious than '1' or '0'.

@tomusborne tomusborne merged commit 1f13ab2 into release/2.0.0 Jan 6, 2025
9 checks passed
@tomusborne tomusborne deleted the feature/dynamic-tags-disable-preview branch January 6, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Tags - add option to disable previews in editor
2 participants