New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce duplicated code in tests #1846

Open

waketzheng wants to merge 2 commits into tortoise:develop from waketzheng:simple-refactor

Contributor

waketzheng commented Jan 9, 2025

Description

Just a simple refactor

Motivation and Context

How Has This Been Tested?

make ci

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          refactor: reduce duplicated code in tests

f6a5f82

waketzheng requested a review from henadzit

January 9, 2025 10:13

codspeed-hq bot commented Jan 9, 2025 •

edited

Loading

CodSpeed Performance Report

Merging #1846 will not alter performance

_{Comparing waketzheng:simple-refactor (06442cc) with develop (8b5ac14)}

Summary

✅ 8 untouched benchmarks


          fix codacy issues

06442cc

coveralls commented Jan 9, 2025 •

edited

Loading

Pull Request Test Coverage Report for Build 12694844707

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.145%

Totals
Change from base Build 12617761088:	0.0%
Covered Lines:	6460
Relevant Lines:	7048

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet