Pass options to getters and setters #194
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apotonick as per our email conversation.
This PR allows to do the following:
The same can be done with setters:
In addition to accepting the
user_options
keyword argument, the methods can also acceptoptions
, if the full options hash is needed.I am not sure if there's a better approach to it.
Also not sure if a test would be required or if the existing tests are fine. I've run into an issue writing a test for it because the test representer (
#representer!
) seems to disregard theexec_context
option for properties and always call getters and setters on the decorated object instead.