Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Navigation: upgrade to support instanced object at top #3069

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

prashanthr6383
Copy link
Collaborator

@prashanthr6383 prashanthr6383 commented Dec 13, 2024

Description

References

Fixes #2927

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@prashanthr6383 prashanthr6383 requested review from coliff and a team as code owners December 13, 2024 06:47
@prashanthr6383 prashanthr6383 linked an issue Dec 13, 2024 that may be closed by this pull request
@prashanthr6383 prashanthr6383 marked this pull request as draft December 13, 2024 06:48
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for moduswebcomponents ready!

Name Link
🔨 Latest commit cfb9baa
🔍 Latest deploy log https://app.netlify.com/sites/moduswebcomponents/deploys/677e1ab98acda100087b77be
😎 Deploy Preview https://deploy-preview-3069--moduswebcomponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50 (🟢 up 3 from production)
Accessibility: 75 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@prashanthr6383 prashanthr6383 marked this pull request as ready for review January 2, 2025 11:08
Copy link

@jewel-shajan jewel-shajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing has been completed, and several known limitations persist, as detailed below. These issues will be resolved in #3089:

  • The expanded state can be closed by clicking outside only when the collapse-on-click-outside option is set to false for the side navigation with a header.
  • Clicking outside the list does not close it.
  • The list color does not adapt to the blue and dark themes.
  • In the expanded state, the list size does not resize according to the width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left Nav: Upgrade to support instanced object at top
3 participants