Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add c# client driver #746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add c# client driver #746

wants to merge 1 commit into from

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Dec 18, 2024

Its a bit inconsistent since I use the .net logo. I chose to do so since .net is the larger target platform for usage. Also the title is longer.. not sure about that either.

Should we switch to the C# logo .. wdyt @georgewfisher @martint @colebow

Preview at https://deploy-preview-746--trino.netlify.app/ecosystem/client-driver#c-sharp

Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably use the C# logo because there's no logo for ADO.NET specifically, but I think it's fine either way.

@mosabua
Copy link
Member Author

mosabua commented Dec 20, 2024

Thanks for the feedback @colebow .. I will check in with @georgewfisher before I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants