Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-gtokernliang committed Dec 24, 2024
1 parent 57b6809 commit 14869e1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/core/trulens/core/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ def tru(self) -> core_connector.DBConnector:
pydantic.PrivateAttr(default_factory=dict)
)

tokens: list[object] = []
tokens: List[object] = []
"""
OTEL context tokens for the current context manager. These tokens are how the OTEL
context api keeps track of what is changed in the context, and used to undo the changes.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def __exit__(self, exc_type, exc_value, exc_tb):

logger.debug("Exiting the OTEL app context.")

while len(self.tokens) > 0:
while self.tokens:
# Clearing the context once we're done with this root span.
# See https://github.com/open-telemetry/opentelemetry-python/issues/2432#issuecomment-1593458684
context_api.detach(self.tokens.pop())
Expand Down

0 comments on commit 14869e1

Please sign in to comment.