Fix new notebook kernel

.github/workflows/build.yml

@@ -47,7 +47,7 @@ jobs:
           pip uninstall -y "jupyter_app_launcher" jupyterlab
 
       - name: Upload extension packages
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: extension-artifacts
           path: dist/jupyter_app_launcher*
@@ -63,7 +63,7 @@ jobs:
         with:
           python-version: '3.9'
           architecture: 'x64'
-      - uses: actions/download-artifact@v3
+      - uses: actions/download-artifact@v4
         with:
           name: extension-artifacts
       - name: Install and Test

.github/workflows/check-release.yml

@@ -19,7 +19,7 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Upload Distributions
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: jupyter_app_launcher-releaser-dist-${{ github.run_number }}
           path: .jupyter_releaser_checkout/dist

.github/workflows/deploy.yml

@@ -32,7 +32,7 @@ jobs:
           cd lite
           jupyter lite build
       - name: Upload (dist)
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: jupyter-app-launcher-demo-dist-${{ github.run_number }}
           path: ./lite/_output
@@ -44,7 +44,7 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/[email protected]
-      - uses: actions/download-artifact@v2
+      - uses: actions/download-artifact@v4
         with:
           name: jupyter-app-launcher-demo-dist-${{ github.run_number }}
           path: ./dist

src/factories/commands/index.ts

@@ -0,0 +1 @@
+export { CommandsFactory } from './commands_factory';

src/factories/local_server/index.ts

@@ -0,0 +1 @@
+export { LocalServerFactory } from './local_server_factory';

src/factories/markdown/index.ts

@@ -0,0 +1 @@
+export { MarkdownFactory } from './markdown_factory';

src/factories/notebook/index.ts

@@ -0,0 +1 @@
+export { NotebookFactory } from './notebook_factory';

src/factories/notebook/notebook_factory.ts

@@ -1,7 +1,6 @@
 import { JupyterFrontEnd } from '@jupyterlab/application';
 import { NotebookPanel } from '@jupyterlab/notebook';
-import { Contents } from '@jupyterlab/services';
-
+import { IDocumentManager } from '@jupyterlab/docmanager';
 import { ILauncherConfiguration } from '../../schema';
 import { IDict, IPanelFactory } from '../../token';
 
@@ -11,34 +10,33 @@ export class NotebookFactory implements IPanelFactory {
     if (!config.sourceCode) {
       return;
     }
+    const { documentManager } = this.options;
     const cwd = args['cwd'];
     const app = this.options.app;
-    const model: Contents.IModel = await app.commands.execute(
-      'docmanager:new-untitled',
-      {
-        path: cwd,
-        type: 'notebook',
-        ext: '.ipynb'
-      }
-    );
-    const doc: NotebookPanel = await app.commands.execute('docmanager:open', {
-      path: model.path
+
+    const model = await documentManager.newUntitled({
+      path: cwd,
+      type: 'notebook',
+      ext: '.ipynb'
     });
-    await doc.context.ready;
-    doc.context.model.fromString(config.sourceCode);
-    // doc.context.model.initialize();
     let renamed = false;
     let index = 0;
+    let newName = model.path;
     while (!renamed) {
       try {
-        await doc.context.rename(
-          `${config.title}${index === 0 ? '' : '-' + index}.ipynb`
-        );
+        newName = `${config.title}${index === 0 ? '' : '-' + index}.ipynb`;
+        await documentManager.rename(model.path, newName);
         renamed = true;
       } catch {
         index += 1;
       }
     }
+    const doc: NotebookPanel = await app.commands.execute('docmanager:open', {
+      path: newName
+    });
+    await doc.context.ready;
+    doc.context.model.fromString(config.sourceCode);
+
     await doc.context.save();
     await doc.sessionContext.ready;
     doc.content.activeCellIndex = 1;
@@ -48,5 +46,6 @@ export class NotebookFactory implements IPanelFactory {
 export namespace NotebookFactory {
   export interface IOptions {
     app: JupyterFrontEnd;
+    documentManager: IDocumentManager;
   }
 }

src/factories/notebook_grid/index.ts

@@ -0,0 +1 @@
+export { NotebookGridFactory } from './notebook_grid_factory';

src/factories/notebook_voila/index.ts

@@ -0,0 +1 @@
+export { NotebookVoilaFactory } from './notebook_voila_factory';

src/factories/terminal/index.ts

@@ -0,0 +1 @@
+export { TerminalFactory } from './terminal_factory';

src/manager_plugin.ts

@@ -7,16 +7,17 @@ import { INotebookTracker, NotebookPanel } from '@jupyterlab/notebook';
 import { IRenderMimeRegistry } from '@jupyterlab/rendermime';
 import { IThemeManager } from '@jupyterlab/apputils';
 
-import { CommandsFactory } from './factories/commands/commands_factory';
-import { LocalServerFactory } from './factories/local_server/local_server_factory';
-import { MarkdownFactory } from './factories/markdown/markdown_factory';
-import { NotebookFactory } from './factories/notebook/notebook_factory';
-import { NotebookGridFactory } from './factories/notebook_grid/notebook_grid_factory';
-import { NotebookVoilaFactory } from './factories/notebook_voila/notebook_voila_factory';
-import { TerminalFactory } from './factories/terminal/terminal_factory';
+import { CommandsFactory } from './factories/commands';
+import { LocalServerFactory } from './factories/local_server';
+import { MarkdownFactory } from './factories/markdown';
+import { NotebookFactory } from './factories/notebook';
+import { NotebookGridFactory } from './factories/notebook_grid';
+import { NotebookVoilaFactory } from './factories/notebook_voila';
+import { TerminalFactory } from './factories/terminal';
 import { URLFactory } from './factories/url/url_factory';
 import { PanelFactoryManager } from './factory_manager';
 import { IPanelFactoryManager } from './token';
+import { IDocumentManager } from '@jupyterlab/docmanager';
 
 export const panelFactoryPlugin: JupyterFrontEndPlugin<IPanelFactoryManager> = {
   id: 'jupyter_app_launcher:panel-factory-manager',
@@ -25,7 +26,8 @@ export const panelFactoryPlugin: JupyterFrontEndPlugin<IPanelFactoryManager> = {
     IRenderMimeRegistry,
     INotebookTracker,
     IEditorServices,
-    NotebookPanel.IContentFactory
+    NotebookPanel.IContentFactory,
+    IDocumentManager
   ],
   optional: [IThemeManager],
   activate: (
@@ -34,6 +36,7 @@ export const panelFactoryPlugin: JupyterFrontEndPlugin<IPanelFactoryManager> = {
     tracker: INotebookTracker,
     editorServices: IEditorServices,
     contentFactory: NotebookPanel.IContentFactory,
+    documentManager: IDocumentManager,
     themeManager?: IThemeManager
   ): IPanelFactoryManager => {
     const manager = new PanelFactoryManager();
@@ -48,7 +51,8 @@ export const panelFactoryPlugin: JupyterFrontEndPlugin<IPanelFactoryManager> = {
     manager.registerFactory('notebook-grid', notebookGridFactory);
 
     const notebookFactory = new NotebookFactory({
-      app
+      app,
+      documentManager
     });
     manager.registerFactory('notebook', notebookFactory);