Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Documentation website loads all the @tabler/icon-react chunks #114

Closed
Valerioageno opened this issue Nov 17, 2024 · 1 comment · Fixed by #153 or #182
Closed

[Bug]: Documentation website loads all the @tabler/icon-react chunks #114

Valerioageno opened this issue Nov 17, 2024 · 1 comment · Fixed by #153 or #182
Assignees
Labels
bug Something isn't working

Comments

@Valerioageno
Copy link
Member

Valerioageno commented Nov 17, 2024

Description

With the tuono dev command the package @tabler/icon-react loads all the chunks at every page load. It is a known bug on tabler side tabler/tabler-icons#1233

Expected behaviour

We should prevent to load all the icons

How to reproduce

Just install the dependencies and run tuono dev and check the network tab

Screenshots

Screenshot 2024-11-17 124729

Tuono version

No response

OS

No response

Browser

No response

Node version

No response

Rust version

No response

Crate version

No response

Node Package Manger version

No response

Additional context

There is a workaround that is not applicable for tuono because there is no interface available for tweaking the vite configuration on user side. We should consider to add this feature within a possible tuono.config.ts file soon!

@Valerioageno Valerioageno added the bug Something isn't working label Nov 17, 2024
@Valerioageno Valerioageno self-assigned this Nov 24, 2024
@marcalexiei
Copy link
Member

Reminder: after releasing tuono.config.ts we have to remember to update tuono version in deploy-documentation workflows:

https://github.com/Valerioageno/tuono/blob/9058f209dd932261256b944ad0117867452ff0fc/.github/workflows/deploy-documentation.yml#L28

@marcalexiei marcalexiei moved this to Backlog in Road to V1 Nov 30, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Road to V1 Nov 30, 2024
@marcalexiei marcalexiei reopened this Nov 30, 2024
@marcalexiei marcalexiei moved this from Done to Ready in Road to V1 Nov 30, 2024
@Valerioageno Valerioageno moved this from Ready to In progress in Road to V1 Nov 30, 2024
@Valerioageno Valerioageno linked a pull request Nov 30, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in Road to V1 Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
2 participants