-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tuono.config.ts
support
#153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcalexiei
reviewed
Nov 26, 2024
Valerioageno
force-pushed
the
init-tuono-config-file
branch
from
November 28, 2024 18:21
e4045e7
to
940eb63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Decision after brain-melting:
|
marcalexiei
reviewed
Nov 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied all the changes we discussed to day and added relevant unit tests.
Let me know if everything checks out also on your end.
marcalexiei
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & Description
This PR is the first iteration for creating the main configuration file
tuono.config.ts
.We are creating the binding for adding the alias option to the vite configuration.
Enable the ability to resolve #114.
How does it work?
Original implementation
When the `tuono.config.ts` file exists, we build it into a commonjs module inside the `.tuono/config/config.js` file. Then any vite script before starting read the file and apply the changes.I decided to create the folder
.tuono/config/
because when we will have to share the config with rust we will need to strip out all the ineligible values for the V8 engine so we will need to create a siblingconfig-server.js
file (built again with vite and maybe a proper plugin).Since the file is in the
./tuono/config
folder using__dirname
will cause issues with the path resolution so, in order to overcome this, I created apath
module that has thepath.join()
function that automatically strips out the wrong filepath and correct__dirname
with the tuono folderNew proposed approach can be found in the comment below