Initial pass on libSQL bindings #597
Draft
+902
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
force-pushed
the
libsql-bindings
branch
2 times, most recently
from
a3969a1 to
12bce01
Compare
This implements libSQL compatible Rust API on top of Limbo's core. The purpose of this is to allow libraries and apps that build on libSQL to use Limbo.
penberg
force-pushed
the
libsql-bindings
branch
from
12bce01 to
1d20bb8
Compare
PThorpe92
reviewed
Jan 6, 2025
| use crate::{Error, Result}; | ||
|
|
||
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum Value { |
There was a problem hiding this comment.
Should this just be one external API crate, both for libsql bindings, as well as extensions? What I mean is this file feels almost identical to one I just wrote.
If this was part of one standard crate that each can link with that exposes these types used in all external interfaces, that way each (sqlite3 extensions, libsql, limbo extensions) can each either use these directly (in the case of limbo extensions), or implement some conversion to it's native types as with the case of sqlite3api.
e.g. for support of sqlite3ext, I would link with that crate, and implement conversion/logic from these types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements libSQL compatible Rust API on top of Limbo's core. The purpose of this is to allow libraries and apps that build on libSQL to use Limbo.