Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5 #15

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Svelte 5 #15

merged 5 commits into from
Nov 8, 2024

Conversation

twm
Copy link
Owner

@twm twm commented Nov 4, 2024

Referencing https://svelte.dev/blog/svelte-5-is-alive

Had to run npm i --force due to this error:

❯ npm i
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: @sveltejs/[email protected]
npm error node_modules/@sveltejs/vite-plugin-svelte
npm error   dev @sveltejs/vite-plugin-svelte@"^4.0.0" from the root project
npm error   peer @sveltejs/vite-plugin-svelte@"^3.0.0" from @sveltejs/[email protected]
npm error   node_modules/@sveltejs/vite-plugin-svelte-inspector
npm error     @sveltejs/vite-plugin-svelte-inspector@"^2.1.0" from @sveltejs/[email protected]
npm error   1 more (@sveltejs/kit)
npm error
npm error Could not resolve dependency:
npm error dev @sveltejs/vite-plugin-svelte@"^4.0.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/svelte
npm error   peer svelte@"^5.0.0-next.96 || ^5.0.0" from @sveltejs/[email protected]
npm error   node_modules/@sveltejs/vite-plugin-svelte
npm error     dev @sveltejs/vite-plugin-svelte@"^4.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error ~/.npm/_logs/2024-11-04T06_37_14_682Z-eresolve-report.txt
npm error A complete log of this run can be found in: ~/.npm/_logs/2024-11-04T06_37_14_682Z-debug-0.log

Fixes #12.

@twm
Copy link
Owner Author

twm commented Nov 4, 2024

Filed sveltejs/svelte#14140 upstream.

twm added 2 commits November 7, 2024 21:35
Address this failure:

    .../halo/src/lib/FracInput.svelte:74:24
    Error: 'input' is possibly 'undefined'. (ts)
            oninput={() => {
                rawValue = input.value
            }}

In practice this is likely harmless, as `bind:this={input}` means that
variable should be bound by the time it emits an input event.
Nonetheless, take the value from the event to avoid closing over `input`.
@twm twm marked this pull request as ready for review November 8, 2024 05:53
@twm twm merged commit ee0a8c7 into trunk Nov 8, 2024
3 checks passed
@twm twm deleted the s5 branch November 8, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5
1 participant