Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RFC) Strip out OPEN-CUTS reporting #3148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

(RFC) Strip out OPEN-CUTS reporting #3148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,15 @@ Options:

The UBports Foundation maintains a various free- and open-source NPM libraries for the UBports Installer.

| Package | Version | Description |
| ------------------------ | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------- |
| `progressive-downloader` | [![version](https://shields.io/npm/v/progressive-downloader)](https://www.npmjs.com/package/progressive-downloader) | Parallel downloads and opportunistic checksum verification |
| `promise-android-tools` | [![version](https://shields.io/npm/v/promise-android-tools)](https://www.npmjs.com/package/promise-android-tools) | Extensive wrapper for ADB, Fastboot, Heimdall |
| `android-tools-bin` | [![version](https://shields.io/npm/v/android-tools-bin)](https://www.npmjs.com/package/android-tools-bin) | Cross-platform binaries for ADB, Fastboot, Heimdall |
| `open-cuts-reporter` | [![version](https://shields.io/npm/v/open-cuts-reporter)](https://www.npmjs.com/package/open-cuts-reporter) | Report test results to [UBports OPEN-CUTS](https://www.open-cuts.org/) |
| Package | Version | Description |
| ------------------------ | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------- |
| `progressive-downloader` | [![version](https://shields.io/npm/v/progressive-downloader)](https://www.npmjs.com/package/progressive-downloader) | Parallel downloads and opportunistic checksum verification |
| `promise-android-tools` | [![version](https://shields.io/npm/v/promise-android-tools)](https://www.npmjs.com/package/promise-android-tools) | Extensive wrapper for ADB, Fastboot, Heimdall |
| `android-tools-bin` | [![version](https://shields.io/npm/v/android-tools-bin)](https://www.npmjs.com/package/android-tools-bin) | Cross-platform binaries for ADB, Fastboot, Heimdall |

## License

Original development by [Marius Gripsgård](http://mariogrip.com/) and [Johannah Sprinz](https://spri.nz). Copyright (C) 2017-2022 [UBports Foundation](https://ubports.com).
Original development by [Marius Gripsgård](http://mariogrip.com/) and [Johannah Sprinz](https://spri.nz). Copyright (C) 2017-2023 [UBports Foundation](https://ubports.com).

This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.

Expand Down
7 changes: 0 additions & 7 deletions __mocks__/open-cuts-reporter.js
View file
Open in desktop

This file was deleted.

162 changes: 0 additions & 162 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
"form-data": "^4.0.0",
"fs-extra": "^11.1.0",
"graphql": "^16.6.0",
"open-cuts-reporter": "^1.0.2",
"progressive-downloader": "^2.0.2",
"promise-android-tools": "^4.0.13",
"ps-tree": "^1.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/lib/mainEvent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ mainEvent.on("user:write:done", () => {
log.info(
"All done! Your device will now reboot and complete the installation. Enjoy exploring Ubuntu Touch!"
);
if (!settings.get("never.opencuts")) {
if (!settings.get("never.reportInstallationResult")) {
setTimeout(() => {
window.send("user:report", true);
}, 1500);
Expand Down
21 changes: 10 additions & 11 deletions src/lib/menuManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,16 @@ class MenuManager {
!settings.get("systemimage.showHiddenChannels")
)
},
{
label: "Never ask for installation result reporting",
checked: settings.get("never.reportInstallationResult"),
type: "checkbox",
click: () =>
settings.set(
"never.reportInstallationResult",
!settings.get("never.reportInstallationResult")
)
},
{
label: "Never ask for udev rules",
checked: settings.get("never.udev"),
Expand All @@ -171,17 +181,6 @@ class MenuManager {
"never.windowsDrivers",
!settings.get("never.windowsDrivers")
)
},
{
label: "Never ask for OPEN-CUTS automatic reporting",
checked: settings.get("never.opencuts"),
type: "checkbox",
click: () =>
settings.set("never.opencuts", !settings.get("never.opencuts"))
},
{
label: "OPEN-CUTS API Token",
click: () => reporter.tokenDialog(mainWindow)
}
]
},
Expand Down
Loading