Suplement Missing Symbolic and Full Color Icons

[ochi12]

I notice that some icons are falling back to hicolor in some apps like Settings and Nautilus.
This PR will either add symlinks or make the icons from scratch.

Task:

please report if I missed some icons

• added all missing icons in gnome-control-center
• added missing icon in nautilus
• added missing icon in Text Editor
• added missing icon in gnome-snapshot
• Yarufy sysprof desktop icon. Fullcolor and symbolic
• added missing icons for sysprof
• Added missing icons for Epiphany

If you see missing or incorrect icon please report below.

[ochi12]

for nautilus emblem icons:

before adwaita fallback	after

Why didn't use the original emblem icons?
Answer: Current implementation of Gnome Files for emblem boxes uses symbolic icons. see nautilus.gresource.xml
Answer2: forced to use plain approach since can't use color properly because of .dim-label.

Question: is there any way to color a svg that doesn't obey externally applied filters? if yes then I can rework the icons to be colored?

Question2: Should I remove the rendered icons under non scalable context since Gnome files now uses svg for its emblem boxes?

[AbuShawarib]

Loading spinner is from libadwaita and is drawn manually in software: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.6/class.Spinner.html

[ochi12]

Loading spinner is from libadwaita and is drawn manually in software: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.6/class.Spinner.html

I dug deeper and found out that gnome shell is also doomed to used AdwSpinner.
What does this mean to your spinner implementation @Muqtxdir

[ochi12]

last missing icon for Nautilus added.

[muqtadir-MM]

I dug deeper and found out that gnome shell is also doomed to used AdwSpinner.
What does this mean to your spinner implementation @Muqtxdir

hi, will check for possible approaches to override the default AdwSpinner when yaru is the applied theme

[ochi12]

hi, will check for possible approaches to override the default AdwSpinner when yaru is the applied theme

i looked upon the source code of AdwSpinner and AdwSpinnerPaintable and the spinner wheel uses GSK,
I saw the snippet for the arc and the circle used

  AdwSpinnerPaintable *self = ADW_SPINNER_PAINTABLE (paintable);
  float radius, line_width;
  GdkRGBA color;
  GskPathBuilder *builder; 
  GskPath *circle_path, *arc_path;  -> here
  GskStroke *stroke;
  double progress;
  float base_angle, start_angle, end_angle, length;
  GskPathPoint start_point, end_point;
  GskPathMeasure *measure;

[AbuShawarib]

Loading spinner is from libadwaita and is drawn manually in software: https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.6/class.Spinner.html

I dug deeper and found out that gnome shell is also doomed to used AdwSpinner. What does this mean to your spinner implementation @Muqtxdir

GNOME shell doesn't depend on libadwaita and has its own spinner.

[ochi12]

GNOME shell doesn't depend on libadwaita and has its own spinner.

I thought I was just trippin but here I found their discussion
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3565

[ochi12]

Yarufied Sysprof fullcolor and symbolic desktop icon

symlink for the symbolic icon

[ochi12]

hi, will check for possible approaches to override the default AdwSpinner when yaru is the applied theme

@muqtadir-MM any update on this?

[AbuShawarib]

GNOME shell doesn't depend on libadwaita and has its own spinner.

I thought I was just trippin but here I found their discussion https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3565

Yes, this gnome shell implementing their own version of a spinner that looks similar to AdwSpinner but it is using different code entirely.

[ochi12]

finally found out how to color the svg emblems of nautilus

@Muqtxdir can you verify if this css entry is correct?

#NautilusViewCell box.dim-label {
	--dim-opacity: 1;
	-gtk-icon-palette: warning rgb(286, 83, 32), success rgb(118, 37, 114), error rgb(199,22,43);
}

[Feichtmeier]

finally found out how to color the svg emblems of nautilus

@Muqtxdir can you verify if this css entry is correct?

#NautilusViewCell box.dim-label {
	--dim-opacity: 1;
	-gtk-icon-palette: warning rgb(286, 83, 32), success rgb(118, 37, 114), error rgb(199,22,43);
}

Theming Nautilus was always a bit of trial and error and black magic. If this works then he's correct I would say :)

[Muqtxdir]

hi,

The problem with overriding specific app's custom styling on libadwaita+gtk4 apps is it's not exposed and can only be achieved if it's done through user space (such as under .config dir in home path)

[ochi12]

@Muqtxdir should I consider some missing icons in Epiphany?

[Muqtxdir]

Hi, sure go for it 🙂

[ochi12]

hi,

The problem with overriding specific app's custom styling on libadwaita+gtk4 apps is it's not exposed and can only be achieved if it's done through user space (such as under .config dir in home path)

yeah I just tested it by building the deb file it doesnt work. It could have been a great solution

[Jupi007]

@ochi12 Did you run the script to generate symlinks from lists?

[ochi12]

@ochi12 Did you run the script to generate symlinks from lists?

yes

[Jupi007]

LGTM
Thanks a lot @ochi12 !