Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatable-translatable package to 1.2.4 fixes #1632 #1637

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

RevantCI
Copy link
Collaborator

@RevantCI RevantCI commented Dec 13, 2023

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

  • If we click on a row to edit it, its position is saved- Last clicked position or the active row where the user is editing, that position is saved- works fine currently.
  • On clicking Preview/ changing columns / closing search it goes back to the clicked row-
  • Only Clicking Preview goes back to last clicked position.
  • Changing Columns goes back to last saved row/ not the last clicked position. BUG
  • Closing Search does not go back to last clicked position. It stays at the beginning of the file. BUG_**
  • The above actions takes place irrespective of the current position. That is if its on the same page or if we navigate to other pages using the left and right arrow at the bottom page navigation menu- If we are just navigating through the pages using right left arrows, that works fine as long as it is going back to last clicked position.

@RevantCI RevantCI added the bug Something isn't working label Dec 13, 2023
Copy link
Collaborator

@Joel-C-Johnson Joel-C-Johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joel-C-Johnson Joel-C-Johnson merged commit 4edb4e7 into develop Dec 13, 2023
4 of 6 checks passed
@RevantCI RevantCI mentioned this pull request Dec 13, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor position goes back to previous clicked location when view Column selections are changed
2 participants