Bugfix / fix tn import (#181)

* bump version * fix missing version * fix missing version --------- Co-authored-by: blm <[email protected]>
unfoldingWord · Mar 11, 2024 · 0a4f31a · 0a4f31a
1 parent 8fa8cad
commit 0a4f31a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tc-source-content-updater",
-  "version": "1.4.23",
+  "version": "1.4.24",
   "description": "Module that updates source content for the desktop application translationCore.",
   "main": "lib/index.js",
   "display": "library",

diff --git a/src/helpers/translationHelps/tnArticleHelpers.js b/src/helpers/translationHelps/tnArticleHelpers.js
@@ -182,6 +182,7 @@ export async function processTranslationNotes(resource, sourcePath, outputPath,
     console.log(`tnArticleHelpers.processTranslationNotes() - have needed original bibles for ${sourcePath}, starting processing`);
     const tsvFiles = fs.readdirSync(sourcePath).filter((filename) => path.extname(filename) === '.tsv');
     const tnErrors = [];
+    let bookCount = 0;
 
     for (const filename of tsvFiles) {
       try {
@@ -201,8 +202,8 @@ export async function processTranslationNotes(resource, sourcePath, outputPath,
         const originalLanguageBibleId = isNewTestament ? NT_ORIG_LANG_BIBLE : OT_ORIG_LANG_BIBLE;
         const version = isNewTestament && ntQuery ? ('v' + ntQuery) : otQuery ? ('v' + otQuery) : null;
         if (!version) {
-          console.warn('tnArticleHelpers.processTranslationNotes() - There was a missing version for book ' + bookId + ' of resource ' + originalLanguageBibleId + ' from ' + resource.downloadUrl);
-          return;
+          console.warn('tnArticleHelpers.processTranslationNotes() - There was a missing original language version for book ' + bookId + ' of resource ' + originalLanguageBibleId + ' from ' + resource.downloadUrl);
+          continue;
         }
         const originalBiblePath = path.join(
           resourcesPath,
@@ -223,6 +224,7 @@ export async function processTranslationNotes(resource, sourcePath, outputPath,
           }
           convertEllipsisToAmpersand(groupData, filepath);
           await formatAndSaveGroupData(groupData, outputPath, bookId);
+          bookCount += 1;
         } else {
           const resource = `${originalLanguageOwner}/${originalLanguageId}_${originalLanguageBibleId}`;
           const message = `tnArticleHelpers.processTranslationNotes() - cannot find '${resource}' at ${originalBiblePath}:`;
@@ -244,6 +246,12 @@ export async function processTranslationNotes(resource, sourcePath, outputPath,
       throw new Error(`${message}:\n${tnErrors.join('\n')}`);
     }
 
+    if (!bookCount) {
+      const message = `tnArticleHelpers.processTranslationNotes() - no books could be processed in ${sourcePath}`;
+      console.error(message);
+      throw new Error(`${message}:\n${tnErrors.join('\n')}`);
+    }
+
     // Generate groupsIndex using tN groupData & tA articles.
     makeSureResourceUnzipped(taCategoriesPath);
     const categorizedGroupsIndex = generateGroupsIndex(outputPath, taCategoriesPath);