Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery] Migrate to WinUI/WinAppSDK #399

Closed
sakshi173 opened this issue Jul 18, 2022 · 4 comments · Fixed by #840
Closed

[Gallery] Migrate to WinUI/WinAppSDK #399

sakshi173 opened this issue Jul 18, 2022 · 4 comments · Fixed by #840
Assignees

Comments

@sakshi173
Copy link
Contributor

Current behavior

progressring ‎- Photos
Lottie ‎- Photos

Expected behavior

progressring correct
Lottie ‎correct

How to reproduce it (as minimally and precisely as possible)

  1. Open Uno Gallery APP
  2. Click Burger Menu on the left top right.
  3. Click "Progress Ring/Bar" from the "Component" list.
  4. Observe that 'ProgressRing/Bar' is missing.
  5. Click "Lottie" from the "Features" list.
  6. Observe that 'Lottie' is missing.

Workaround

No response

Works on UWP/WinUI

No response

Environment

No response

NuGet package version(s)

No response

Affected platforms

iOS, Android

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@kazo0 kazo0 self-assigned this Jul 22, 2022
@jeromelaban
Copy link
Member

This issue is specific to the canary, and won't be fixed explicitly. The reason for this is the fact that SkiaSharp.Views.Uno does not have a net6-android/ios target (because of mixed net6/xamarin builds complexities), and it is only available on SkiaSharp.Views.Uno.WinUI.

The way forward for this is to migrate the Gallery app to use WinUI/WinAppSDK, so that the net6 targets use the correct SkiaSharp dependency.

@jeromelaban jeromelaban changed the title [Gallery][Android/iOS] progressRing/Bar and Lottie is missing. [Gallery][Android/iOS] Migrate to WinUI/WinAppSDK Aug 2, 2022
@jeromelaban jeromelaban changed the title [Gallery][Android/iOS] Migrate to WinUI/WinAppSDK [Gallery] Migrate to WinUI/WinAppSDK Aug 2, 2022
@kazo0 kazo0 transferred this issue from unoplatform/uno Aug 2, 2022
@kazo0
Copy link
Contributor

kazo0 commented Aug 2, 2023

Currently blocking the x64 build because of this

@kazo0
Copy link
Contributor

kazo0 commented Aug 4, 2023

App fails to build in release for net7.0-ios as a result of dotnet/runtime#90032

Current workaround is to add this to the .Mobile.csproj

<ItemGroup Condition="'$(Configuration)'=='Release'">
	<TrimmableAssembly Include="CommunityToolkit.WinUI.UI" />
</ItemGroup>

@kazo0 kazo0 closed this as completed in #840 Aug 6, 2023
@sakshi173
Copy link
Contributor Author

Verified this issue is fixed, closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants