Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move to WinUI/WinAppSDK #840

Merged
merged 1 commit into from
Aug 6, 2023
Merged

chore: move to WinUI/WinAppSDK #840

merged 1 commit into from
Aug 6, 2023

Conversation

kazo0
Copy link
Contributor

@kazo0 kazo0 commented Aug 2, 2023

closes #399

@kazo0 kazo0 marked this pull request as draft August 2, 2023 19:30
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

7 similar comments
@github-actions
Copy link

github-actions bot commented Aug 2, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@kazo0 kazo0 marked this pull request as ready for review August 3, 2023 22:01
@Xiaoy312 Xiaoy312 self-requested a review August 3, 2023 22:03
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 3, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Aug 4, 2023
View reviewed changes
Uno.Gallery/Uno.Gallery.Shared/App.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/App.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/App.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Extensions/XamlDisplayExtensions.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Uno.Gallery.Shared.shproj Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Views/SamplePages/MediaPlayerElementSamplePage.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Views/SamplePages/GamepadSamplePage.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Views/SamplePages/FileFolderPickerSamplePage.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Views/SamplePages/EmailManagerSamplePage.xaml.cs Outdated Show resolved Hide resolved
Uno.Gallery/Uno.Gallery.Shared/Views/SamplePages/GridViewSamplePage.xaml.cs Outdated Show resolved Hide resolved
agneszitte
agneszitte reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@agneszitte agneszitte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazo0 I grabbed the PR branch and getting this exception for x86 & x64. Missing Properties folder (gitignore update needed)
image

@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@kazo0
Copy link
Contributor Author

kazo0 commented Aug 4, 2023

Current issues:

@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

7 similar comments
@github-actions
Copy link

github-actions bot commented Aug 4, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

3 similar comments
@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

4 similar comments
@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@kazo0 kazo0 force-pushed the dev/sb/winui-convert branch from b6441db to daa59c9 Compare August 6, 2023 19:22
@github-actions
Copy link

github-actions bot commented Aug 6, 2023 •
edited by unfurl-links bot
Loading

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-840.eastus2.3.azurestaticapps.net

@kazo0 kazo0 merged commit 427eda6 into master Aug 6, 2023
@kazo0 kazo0 deleted the dev/sb/winui-convert branch August 6, 2023 19:52
@kazo0
Copy link
Contributor Author

kazo0 commented Aug 8, 2023 •
edited by unfurl-links bot
Loading

https://github.com/Mergifyio backport legacy/4x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link

mergify bot commented Aug 8, 2023 •
edited
Loading

backport legacy/4x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 8, 2023
Merged
@morning4coffe-dev morning4coffe-dev mentioned this pull request Sep 5, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xiaoy312 Xiaoy312 Xiaoy312 left review comments

@agneszitte agneszitte agneszitte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Gallery] Migrate to WinUI/WinAppSDK
3 participants
@kazo0 @Xiaoy312 @agneszitte