YAML and JSON-based detection for games and RCS. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! I'll test it ASAP. |
urwrstkn8mare
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced most registry-based detection with YAML and JSON-based detection for the games and RiotClientServices.
Created two new helper functions in utils/misc: get_product_settings_path(game_id) and get_riot_client_installs_path().
I'm not currently aware of how to detect Vanguard's location without using the registry and had to leave the code for that in place.
Merged into dev and fixed utils import to utils.misc as well as some miscellaneous typos.
Fixes issues #6 and possibly #10.