Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTF23 Review End Page #198

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from
Draft

INTF23 Review End Page #198

wants to merge 29 commits into from

Conversation

LucyWuu
Copy link
Collaborator

@LucyWuu LucyWuu commented Dec 20, 2023

Notion ticket link

[FE] Review page - End Page

Implementation description

  • Finished the left half UI
  • Finished the skills category & comment UI with their state setups on the right half of the page.
  • Next steps:
  • display the UI for second choice
  • bundle the data together & send them to the backend db
  • need to create a new graphql query for such action

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

aaggarwal10 and others added 29 commits June 28, 2023 18:08
* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: TW1234567 <[email protected]>
Co-authored-by: Thomas Wu <[email protected]>
* Add review scoring pages

* Only allow 1 through 5 for review scores

* Fix linter issues

* Fix review comments
…eperating react from fetch calls (#151)

Co-authored-by: Thomas Wu <[email protected]>
Co-authored-by: Thomas Wu <[email protected]>
* Add question answer component and dummy data

* fix login bug by removing onauthChange callback (#148)

* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: Thomas Wu <[email protected]>

* Resolve package conflict to allow for MUIDataTable style (#149)

* Fix Team (#152)

* Changing Application Roles (#155)

* fix login bug by removing onauthChange callback (#148) (#150)

* fix login bug by removing onauthChange callback

* lint

* remove unused imports

---------

Co-authored-by: TW1234567 <[email protected]>
Co-authored-by: Thomas Wu <[email protected]>

* add left content banner with people image

* Add blueprint images to left content panel

* Add report conflict modal

* fix report conflict modal style

* move modal as an optional button in the right titele

* add empty alt text for decorative images

---------

Co-authored-by: TW1234567 <[email protected]>
Co-authored-by: Thomas Wu <[email protected]>
Co-authored-by: River Stanley <[email protected]>
Co-authored-by: Anish Aggarwal <[email protected]>
* rough

* implement and use ProtectedApplicaiton

* linting

* edit error handling for verfiying user

* revert secrets.ts change

---------

Co-authored-by: Thomas Wu <[email protected]>
* updates application dashboard

* refactoring table styling

* updates dynamc applicant filtering, app count

* refactoring

* added table options

* removed toolbar

* readding toolbar lol

* fetching second choice status

* custom sorting function for name column

* adds for styling for second choice status

---------

Co-authored-by: aanxniee <[email protected]>
* updates to make search, sorting, and filtering work

* moved application table query to queries.ts

* moved mui theme to utils

* refactoring get style functions + moved to utils

* fixed review rerouting issue

* removes mui comments and small updates

* runs lint and prettier

---------

Co-authored-by: aanxniee <[email protected]>
* moves dashboard dropdown menu + updates styling

* fixes styling issues for status and second choice status
…185)

* 10/26/2023

* Co-authored-by: anushehatiff <[email protected]>

* added heet's reviewInfoStage & type changes

---------

Co-authored-by: HeetShah <[email protected]>
* creates query for secondchoicerole, new table tab

* added prop for whichChoiceTab

* fade out inactive tab

* clean up code

* remove space

* add types to type file, rename tabletitle, remove edit buttom temp.

* Update yarn.lock

* t

* tme

* l

* revert yarn.lock

* Update yarn.lock

* Update yarn.lock

* old yarn.lock
* adds conditional rendering based on selection on dropdown menu

* adds table columns for review table

* [INTF23] Second choice tab (#184)

* creates query for secondchoicerole, new table tab

* added prop for whichChoiceTab

* fade out inactive tab

* clean up code

* remove space

* add types to type file, rename tabletitle, remove edit buttom temp.

* Update yarn.lock

* t

* tme

* l

* revert yarn.lock

* Update yarn.lock

* Update yarn.lock

* old yarn.lock

* lints (#190)

* lints

* adds default value to dropdown menu

* adds conditional rendering based on selection on dropdown menu

* adds table columns for review table

* added second choice tabs to review table

* adds inner table to expandable row

* Revert "adds inner table to expandable row"

This reverts commit a801855.

---------

Co-authored-by: Jesse Li <[email protected]>
Co-authored-by: Heet Shah <[email protected]>
Co-authored-by: HeetShah <[email protected]>
* update SKL page

update SKL page

* refactoring fetching application and render data

* linting

* loop through all role specific questions

---------

Co-authored-by: HeetShah <[email protected]>
@LucyWuu LucyWuu requested a review from HeetShah December 20, 2023 03:20
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for uwblueprint failed.

Name Link
🔨 Latest commit 931a87e
🔍 Latest deploy log https://app.netlify.com/sites/uwblueprint/deploys/65825d847f57f10008538bf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants