Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intw24 review end page #208

Open
wants to merge 6 commits into
base: staging
Choose a base branch
from
Open

Intw24 review end page #208

wants to merge 6 commits into from

Conversation

Kriti1400
Copy link
Collaborator

@Kriti1400 Kriti1400 commented Feb 6, 2024

Notion ticket link

Ticket Name

Implementation description

  • Built and styled the review end page such that it displays the information correctly, has the correct functionality, and matches Figma design presented in the ticket
  • connected the backend to send all the review page data to the database

Steps to test

1.Run the frontend and backend
2. Go to the review dashboard on the frontend with your credentials and navigate to the end page
3. ensure that the UI for the end page is correct
4. click the submit button and ensure everything shows up correctly in the database

What should reviewers focus on?

  • Ensure UI matches implementation
  • Ensure behaviour is correct when buttons are clicked
  • ensure everything is sent correctly to the backend

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
image image

Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for uwblueprint failed.

Name Link
🔨 Latest commit e33092d
🔍 Latest deploy log https://app.netlify.com/sites/uwblueprint/deploys/65c18507c9930900082cf18d

@aanxniee aanxniee changed the base branch from main to staging February 8, 2024 00:11
@Kriti1400 Kriti1400 changed the title Intw24 review end page DRAFT Intw24 review end page Apr 3, 2024
@Kriti1400 Kriti1400 marked this pull request as ready for review April 3, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant