Node: fix flaky test (#2657)

fix tests Signed-off-by: Yury-Fridlyand <[email protected]>
valkey-io · Dec 10, 2024 · 3542b2a · 3542b2a
1 parent 03c7753
commit 3542b2a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/node/package.json b/node/package.json
@@ -34,8 +34,8 @@
         "fix-protobuf-file": "replace 'this\\.encode\\(message, writer\\)\\.ldelim' 'this.encode(message, writer && writer.len ? writer.fork() : writer).ldelim' src/ProtobufMessage.js",
         "test": "npm run build-test-utils && jest --verbose --testPathIgnorePatterns='ServerModules'",
         "test-dbg": "npm run build-test-utils && jest --runInBand",
-        "test-minimum": "npm run build-test-utils && jest --verbose --testNamePattern='^(.(?!(GlideJson|GlideFt|pubsub|kill)))*$'",
-        "test-modules": "npm run build-test-utils && jest --verbose --testNamePattern='(GlideJson|GlideFt)'",
+        "test-minimum": "npm run build-test-utils && jest --verbose --runInBand --testNamePattern='^(.(?!(GlideJson|GlideFt|pubsub|kill)))*$'",
+        "test-modules": "npm run build-test-utils && jest --verbose --runInBand --testNamePattern='(GlideJson|GlideFt)'",
         "build-test-utils": "cd ../utils && npm i && npm run build",
         "lint:fix": "npm run install-linting && npx eslint -c ../eslint.config.mjs --fix && npm run prettier:format",
         "lint": "npm run install-linting && npx eslint -c ../eslint.config.mjs && npm run prettier:check:ci",

diff --git a/node/tests/GlideClient.test.ts b/node/tests/GlideClient.test.ts
@@ -297,14 +297,16 @@ describe("GlideClient", () => {
             );
             const key1 = uuidv4();
             const key2 = uuidv4();
-            const value = uuidv4();
+            const value = "value";
 
             const transaction1 = new Transaction().set(key1, value).dump(key1);
 
             // Since DUMP gets binary results, we cannot use the string decoder here, so we expected to get an error.
             await expect(
                 client.exec(transaction1, { decoder: Decoder.String }),
-            ).rejects.toThrow("invalid utf-8 sequence of");
+            ).rejects.toThrow(
+                /invalid utf-8 sequence|incomplete utf-8 byte sequence/,
+            );
 
             const result = await client.exec(transaction1, {
                 decoder: Decoder.Bytes,

diff --git a/node/tests/GlideClusterClient.test.ts b/node/tests/GlideClusterClient.test.ts
@@ -276,13 +276,13 @@ describe("GlideClusterClient", () => {
                 getClientConfigurationOption(cluster.getAddresses(), protocol),
             );
 
-            const key = "key";
+            const key = uuidv4();
             const value = "value";
             const valueEncoded = Buffer.from(value);
             expect(await client.set(key, value)).toEqual("OK");
             // Since DUMP gets binary results, we cannot use the default decoder (string) here, so we expected to get an error.
             await expect(client.customCommand(["DUMP", key])).rejects.toThrow(
-                "invalid utf-8 sequence",
+                /invalid utf-8 sequence|incomplete utf-8 byte sequence/,
             );
 
             const dumpResult = await client.customCommand(["DUMP", key], {