Fix test failures for Node client

Signed-off-by: Jonathan Louie <[email protected]>
valkey-io · Jan 8, 2025 · 62ec79d · 62ec79d
1 parent b75e286
commit 62ec79d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/node/tests/GlideClusterClient.test.ts b/node/tests/GlideClusterClient.test.ts
@@ -326,16 +326,18 @@ describe("GlideClusterClient", () => {
 
             if (!cluster.checkIfServerVersionLessThan("7.0.0")) {
                 const transaction = new ClusterTransaction()
-                    .configSet({ timeout: "2000", logfile: "foo" })
-                    .configGet(["timeout", "logfile"]);
+                    .configSet({ timeout: "2000", "cluster-node-timeout": "16000" })
+                    .configGet(["timeout", "cluster-node-timeout"]);
                 const result = await client.exec(transaction);
-                expect(result).toEqual([
-                    "OK",
-                    convertRecordToGlideRecord({
-                        timeout: "2000",
-                        logfile: "foo",
-                    }),
-                ]);
+                expect(result[0]).toEqual("OK");
+                const expectedConfigGetResult = convertRecordToGlideRecord({
+                    timeout: "2000",
+                    "cluster-node-timeout": "16000",
+                });
+                expect(result[1][0]["key"]).toEqual("cluster-node-timeout");
+                expect(result[1][0]["value"]).toEqual("16000");
+                expect(result[1][1]["key"]).toEqual("timeout");
+                expect(result[1][1]["value"]).toEqual("2000");
             }
         },
         TIMEOUT,

diff --git a/node/tests/SharedTests.ts b/node/tests/SharedTests.ts
@@ -1245,21 +1245,21 @@ export function runBaseTests(config: {
                     "cluster-node-timeout",
                 ])) as Record<string, GlideString>;
                 expect(
-                    await client.configSet({ timeout: "1000", cluster-node-timeout: "16000" }),
+                    await client.configSet({ timeout: "1000", "cluster-node-timeout": "16000" }),
                 ).toEqual("OK");
                 const currParameterValues = (await client.configGet([
                     "timeout",
                     "cluster-node-timeout",
                 ])) as Record<string, GlideString>;
                 expect(currParameterValues).toEqual({
                     timeout: "1000",
-                    cluster-node-timeout: "16000",
+                    "cluster-node-timeout": "16000",
                 });
                 /// Revert to the previous configuration
                 expect(
                     await client.configSet({
                         timeout: prevTimeout["timeout"],
-                        logfile: prevClusterNodeTimeout["cluster-node-timeout"],
+                        "cluster-node-timeout": prevClusterNodeTimeout["cluster-node-timeout"],
                     }),
                 ).toEqual("OK");
             }, protocol);