Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORT: Review unapproved/unknown licenses #2774

Closed
3 tasks
ikolomi opened this issue Nov 28, 2024 · 2 comments
Closed
3 tasks

ORT: Review unapproved/unknown licenses #2774

ikolomi opened this issue Nov 28, 2024 · 2 comments
Assignees
Labels
dependency Dependency management Tech debt
Milestone

Comments

@ikolomi
Copy link
Collaborator

ikolomi commented Nov 28, 2024

Description

The current ORT validation runs produce unknown/unapproved licenses, for example, this run:
https://github.com/valkey-io/valkey-glide/actions/runs/12060233555/job/33630281736

produced the following list:

Package_name: Crate::option-ext:0.2.0, Language: Python, License: MPL-2.0
Package_name: Crate::ring:0.17.8, Language: Python, License: NOASSERTION
Package_name: Crate::unicode-ident:1.0.14, Language: Python, License: (Apache-2.0 OR MIT) AND Unicode-3.0
Package_name: PyPI::pathspec:0.12.1, Language: Python, License: MPL-2.0
Package_name: PyPI::pathspec:0.12.1, Language: Python, License: MPL-2.0
Package_name: PyPI::pytest-metadata:3.1.1, Language: Python, License: MPL-2.0
Package_name: PyPI::pytest-metadata:3.1.1, Language: Python, License: MPL-2.0
Package_name: Crate::option-ext:0.2.0, Language: Node, License: MPL-2.0
Package_name: Crate::ring:0.17.8, Language: Node, License: NOASSERTION
Package_name: Crate::unicode-ident:1.0.14, Language: Node, License: (Apache-2.0 OR MIT) AND Unicode-3.0
Package_name: NPM::pause-stream:0.0.11, Language: Node, License: Apache-2.0 AND MIT
Package_name: Crate::option-ext:0.2.0, Language: Java, License: MPL-2.0
Package_name: Crate::ring:0.17.8, Language: Java, License: NOASSERTION
Package_name: Crate::unicode-ident:1.0.14, Language: Java, License: (Apache-2.0 OR MIT) AND Unicode-3.0
Package_name: Maven:org.json:json:20231013, Language: Java, License: LicenseRef-scancode-public-domain-disclaimer
Package_name: Maven:org.json:json:20231013, Language: Java, License: LicenseRef-scancode-public-domain-disclaimer
Package_name: Crate::option-ext:0.2.0, Language: Rust, License: MPL-2.0
Package_name: Crate::ring:0.17.8, Language: Rust, License: NOASSERTION
Package_name: Crate::unicode-ident:1.0.14, Language: Rust, License: (Apache-2.0 OR MIT) AND Unicode-3.0

This breaks AWS AppSec requirements, we have to deal with it by either extended the set of approved licenses or removing the packages

Checklist

  • Task item 1
  • Task item 2
  • Task item 3

Additional Notes

No response

@ikolomi ikolomi added the dependency Dependency management label Nov 28, 2024
@ikolomi ikolomi moved this to Backlog in Valkey-GLIDE - internal Nov 28, 2024
@BoazBD
Copy link
Collaborator

BoazBD commented Dec 30, 2024

Most of the work is completed in #2890.
The remaining tasks depend on Viral (Senior Open Source Engineer) to approve or reject some of the packages we are using.

As a result, the estimated completion time is between 1 to 5 days, depending on his response.

@BoazBD
Copy link
Collaborator

BoazBD commented Jan 7, 2025

Unapproved/unknown licenses list is now empty.

@BoazBD BoazBD closed this as completed Jan 7, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Valkey-GLIDE - internal Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency management Tech debt
Projects
Status: Done
Development

No branches or pull requests

3 participants