Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ORT to skip approved packages or those under testing #2890

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Update ORT to skip approved packages or those under testing #2890

merged 6 commits into from
Jan 2, 2025

Conversation

BoazBD
Copy link
Collaborator

@BoazBD BoazBD commented Dec 30, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): 2774, 2709

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@BoazBD BoazBD force-pushed the boaz/fix-ort-script branch from 3d7c939 to 23fbcf3 Compare December 30, 2024 14:16
@BoazBD BoazBD force-pushed the boaz/fix-ort-script branch from cfbffe9 to 54b80a0 Compare December 30, 2024 15:03
@BoazBD BoazBD mentioned this pull request Dec 30, 2024
Closed
3 tasks
@BoazBD BoazBD marked this pull request as ready for review December 31, 2024 08:38
@BoazBD BoazBD requested a review from a team as a code owner December 31, 2024 08:38
@BoazBD BoazBD requested a review from barshaul December 31, 2024 08:39
barshaul
barshaul requested changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments inline.
Also- missing a change in python's DEVELOPER.md file now with the new dev_requirements file

python/pyproject.toml Outdated Show resolved Hide resolved
python/requirements.txt Outdated Show resolved Hide resolved
.github/workflows/build-python-wrapper/action.yml Outdated Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
.github/workflows/python.yml Show resolved Hide resolved
utils/get_licenses_from_ort.py Show resolved Hide resolved
@BoazBD BoazBD force-pushed the boaz/fix-ort-script branch from 5df0480 to edb02e3 Compare January 1, 2025 12:55
@BoazBD BoazBD force-pushed the boaz/fix-ort-script branch from edb02e3 to 64cca3f Compare January 1, 2025 13:04
barshaul
barshaul reviewed Jan 2, 2025
View reviewed changes
python/pyproject.toml Outdated Show resolved Hide resolved
barshaul
barshaul approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the last comments & ship 🚀

@BoazBD @barshaul
Update python/pyproject.toml
49c0a57 
Co-authored-by: Bar Shaul <[email protected]>
Signed-off-by: BoazBD <[email protected]>
@BoazBD BoazBD merged commit 91eb2cf into main Jan 2, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barshaul barshaul barshaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoazBD @barshaul