Add node test for checking exported symbols #2835
Conversation
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Failure
|
|
||
| ```bash | ||
|
|
||
| Build node package: |
There was a problem hiding this comment.
Move nodes outside of code block or add a comment
| ```bash | ||
|
|
||
| Build node package: | ||
| cd node |
There was a problem hiding this comment.
Remove a black space ident in the entire block
| cd node | |
| cd node |
| - openssl | ||
| - openssl-dev | ||
| - rustup | ||
| - npm |
There was a problem hiding this comment.
Is it done by a linter?
There was a problem hiding this comment.
yes
| npm run test | ||
| npm run test -- --testNamePattern="Exported symbols test" |
There was a problem hiding this comment.
Isn't this test run in scope of npm run test task?
There was a problem hiding this comment.
Yes, I will add a comment, for running a specific test.
| npm run build | ||
| npm run build:release |
There was a problem hiding this comment.
Why need to build it twice?
| }, | ||
| "optionalDependencies": { | ||
| "${scope}valkey-glide-darwin-arm64": "${package_version}", | ||
| "${scope}valkey-glide-darwin-x64": "${package_version}", |
There was a problem hiding this comment.
| "${scope}valkey-glide-darwin-x64": "${package_version}", |
This one is not supported now
There was a problem hiding this comment.
Will remove. Thanks.
There was a problem hiding this comment.
Can't you update node/npm/glide/package.json instead? If no, we have to maintain these 2 files in sync.
There was a problem hiding this comment.
package.json.tmpl has some changes to run this in local.
Later, we will find a solution that works for CI. All the env variables will need to decided accordingly.
Cleaning up the package.json will be part of that task.
| // const rustClientBuildFolder = './node_modules/@valkey/valkey-glide-impl/rust-client/'; | ||
| // const filesWithNodeCode = [...await getFiles(implBuildFolder), ...await getFiles(rustClientBuildFolder)]; |
There was a problem hiding this comment.
delete if it is not needed
There was a problem hiding this comment.
Will update this in next commit.
node/package.json.tmpl
Outdated
There was a problem hiding this comment.
Same with this file
There was a problem hiding this comment.
This test is not exectued in CI!
There was a problem hiding this comment.
Updating the CI will be taken up separately. The scope of this task is to run this test on local.
prateek-kumar-improving
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
Issue link
This Pull Request is linked to issue (URL): #2335
The added test can be run on local using the instructions in developer.md file.
The scope of this task is to only run the test on local. Running the test on CI is not part of this PR.
Checklist
Before submitting the PR make sure the following are checked: