Core: Extract proto from socket-layer feature.
#2861
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
commented
Dec 24, 2024
| @@ -13,10 +13,11 @@ fn build_protobuf() { | |||
| .input("src/protobuf/response.proto") | |||
| .input("src/protobuf/connection_request.proto") | |||
| .customize(customization_options) | |||
| .out_dir("src/generated") | |||
There was a problem hiding this comment.
It is not mandatory, but it puts generated files to a place where they could be found
| @@ -28,7 +28,7 @@ use tokio::runtime::Runtime; | |||
| #[derive(Debug)] | |||
| pub struct CommandResponse { | |||
| response_type: ResponseType, | |||
| int_value: c_long, | |||
| int_value: i64, | |||
There was a problem hiding this comment.
c_long is i64, but on windows is i32 🤦
yipin-chen
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes for clients or user API.
But we can build non-UDS clients on windows now: