-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: refactor writeOrBufferCommandRequest (#2675) #2916
base: main
Are you sure you want to change the base?
Conversation
Please add a changelog entry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Looks good.
Since it's the communication piece of the Node client, can you run the benchmark before and after to make sure we didn't miss anything that is decreasing the performance?
I am not sure whether it should be in the changelog, since it's internal and not user facing. |
This is my benchmark results on my local machine The two benchmark results appear to be almost identical. benchmark-on-feature-branch.csv |
- seperate createWritePromise by comand_request category - get value from split pointer at processResponse Signed-off-by: jhpung <[email protected]>
40bff6c
to
f9ccc92
Compare
Issue link
This Pull Request is linked to issue (URL): #2365
Checklist
Before submitting the PR make sure the following are checked: