Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: refactor writeOrBufferCommandRequest (#2675) #2916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhpung
Copy link
Collaborator

@jhpung jhpung commented Jan 5, 2025

Issue link

This Pull Request is linked to issue (URL): #2365

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jhpung jhpung added node Node.js wrapper Optimization Optimization matter such as cleaner code, performance etc labels Jan 5, 2025
@jhpung jhpung requested a review from avifenesh January 5, 2025 13:46
@jhpung jhpung self-assigned this Jan 5, 2025
@jhpung jhpung requested a review from a team as a code owner January 5, 2025 13:46
node/src/BaseClient.ts Outdated Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator

Please add a changelog entry

Copy link
Collaborator

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks good.
Since it's the communication piece of the Node client, can you run the benchmark before and after to make sure we didn't miss anything that is decreasing the performance?

@avifenesh
Copy link
Collaborator

Please add a changelog entry

I am not sure whether it should be in the changelog, since it's internal and not user facing.
@ikolomi Do we add all to the changelog, or just release note relevant changes?

@jhpung
Copy link
Collaborator Author

jhpung commented Jan 7, 2025

This is my benchmark results on my local machine

The two benchmark results appear to be almost identical.

benchmark-on-feature-branch.csv
benchmark-on-main-branch.csv

- seperate createWritePromise by comand_request category
- get value from split pointer at processResponse

Signed-off-by: jhpung <[email protected]>
@jhpung jhpung force-pushed the chore/refactorCreateWritePromise branch from 40bff6c to f9ccc92 Compare January 7, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper Optimization Optimization matter such as cleaner code, performance etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants